Skip to content

Conversation

chromy
Copy link
Contributor

@chromy chromy commented Aug 14, 2025

Make two changes to what we report to Sentry for crashes:

  1. Set 'environment' to SENTRY_REGION / SENTRY_ENVIRONMENT so rather
    than being 'production' or 'development' it's 'us', 'de', etc.
  2. Set 'release' to the git sha we are building at.

@chromy chromy force-pushed the chromy/2025-08-14-report-releases branch from 1722e12 to 4573ed1 Compare August 14, 2025 20:17
Copy link

codecov bot commented Aug 14, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 77.78%. Comparing base (c8c5a85) to head (17a3e7f).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/launchpad/sentry_sdk_init.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #291      +/-   ##
==========================================
+ Coverage   77.77%   77.78%   +0.01%     
==========================================
  Files         142      142              
  Lines       11143    11141       -2     
  Branches     1185     1184       -1     
==========================================
  Hits         8666     8666              
+ Misses       2057     2055       -2     
  Partials      420      420              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@chromy chromy force-pushed the chromy/2025-08-14-report-releases branch 2 times, most recently from 6e18ca1 to 321d767 Compare August 14, 2025 20:20
@chromy chromy force-pushed the chromy/2025-08-14-report-releases branch from 321d767 to 810b06f Compare August 15, 2025 10:24
@chromy chromy force-pushed the chromy/2025-08-14-report-releases branch 2 times, most recently from 9b9865b to b4f4b5a Compare August 28, 2025 13:49
Make two changes to what we report to Sentry for crashes:
1. Set 'environment' to SENTRY_REGION / SENTRY_ENVIRONMENT so rather
   than being 'production' or 'development' it's 'us', 'de', etc.
2. Set 'release' to the git sha we are building at.
@chromy chromy force-pushed the chromy/2025-08-14-report-releases branch from b4f4b5a to 17a3e7f Compare August 28, 2025 14:06
@chromy chromy merged commit 77b1694 into main Aug 28, 2025
17 checks passed
@chromy chromy deleted the chromy/2025-08-14-report-releases branch August 28, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants